Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make network validation friendlier, especially to corp networks #5802

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Make network validation friendlier, especially to corp networks #5802

merged 1 commit into from
Oct 31, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Oct 31, 2019 •
edited
Loading

  • Removes direct network connectivity check. It's new, and there isn't enough signal yet on it's usefulness. The other two checks (DNS & HTTPS) are enough for nearly every user.
  • Moves noisy command-output to glog.Warningf
  • Provides more appropriate advice if --image-repository is unavailable

Fixes #5793

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg mentioned this pull request Oct 31, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
gclawes
gclawes approved these changes Oct 31, 2019
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #5802 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5802   +/-   ##
=======================================
  Coverage   36.58%   36.58%           
=======================================
  Files         110      110           
  Lines        8096     8096           
=======================================
  Hits         2962     2962           
  Misses       4745     4745           
  Partials      389      389
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 20.36% <0%> (ø) ⬆️

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2019
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 31, 2019
@tstromberg tstromberg merged commit 9b4534c into kubernetes:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@gclawes gclawes gclawes approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minikube attempts to connect to internet when using http_proxy/https_proxy
5 participants
@tstromberg @k8s-ci-robot @codecov-io @gclawes @sharifelgamal